feat: combine services across different httproutes for traditional routes #6711
+1,828
−417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
feat/combine_service_across_httproutes
branch
3 times, most recently
from
01ab6bc
to
ffa0d85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6711 +/- ##
=======================================
+ Coverage 77.8% 78.2% +0.3%
=======================================
Files 204 205 +1
Lines 23870 24238 +368
=======================================
+ Hits 18590 18965 +375
+ Misses 4337 4318 -19
- Partials 943 955 +12 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/combine_service_across_httproutes
branch
from
ffa0d85
to
3f8b4b8
Compare
randmonkey
changed the title
randmonkey
force-pushed
the
feat/combine_service_across_httproutes
branch
from
6d266d3
to
6176841
Compare
pmalek
reviewed
Nov 27, 2024
randmonkey
force-pushed
the
feat/combine_service_across_httproutes
branch
from
68e5fff
to
aaf48ad
Compare
randmonkey
force-pushed
the
feat/combine_service_across_httproutes
branch
from
aaf48ad
to
80affc6
Compare
randmonkey
force-pushed
the
feat/combine_service_across_httproutes
branch
from
80affc6
to
ffa3bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Combine rules sharing the same backends cross
HTTPRoutes in the same namespace into a single Kong gateway service.This PR resolves the case for traditional routes (
traditionalortraditional_compatiblerouter flavor).Which issue this PR fixes:
fixes #6726
Special notes for your reviewer:
Moved part of code for translating
HTTPRouteto the packagesubtranslator.GenerateKongRouteFromTranslationis used by the validation server so this function and its dependencies are not touched.backendref.goandbackendref_test.goare copied intosubtranslatorpackage since the original one is still used byGRPCRoutetranslator. Will process them in the later PR.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR